Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update keras cv docs to the newest release #920

Merged
merged 20 commits into from Jun 21, 2022
Merged

Update keras cv docs to the newest release #920

merged 20 commits into from Jun 21, 2022

Conversation

LukeWood
Copy link
Contributor

No description provided.

@LukeWood
Copy link
Contributor Author

Ok, @fchollet this is now ready for review!

fchollet
fchollet reviewed Jun 17, 2022
View reviewed changes
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

scripts/.gitignore Outdated Show resolved Hide resolved
scripts/autogen.py Outdated Show resolved Hide resolved
scripts/cv_api_master.py Outdated Show resolved Hide resolved
templates/keras_cv/bounding_box/index.md Show resolved Hide resolved
templates/keras_cv/bounding_box/index.md Outdated Show resolved Hide resolved
templates/keras_cv/index.md Show resolved Hide resolved
templates/keras_cv/index.md Outdated Show resolved Hide resolved
templates/keras_cv/index.md Show resolved Hide resolved
templates/keras_cv/index.md Show resolved Hide resolved
templates/keras_cv/index.md Outdated Show resolved Hide resolved
@LukeWood
Copy link
Contributor Author

@fchollet rebased and addressed all comments. Thanks!

@LukeWood
Copy link
Contributor Author

@fchollet added the GenFiles!

@LukeWood
Copy link
Contributor Author

LukeWood commented Jun 20, 2022 •
edited

@fchollet also added a models API entry, we can write a real page for each when we have more models + the "scoreboard".

Let me know if anything else is needed to merge!

@LukeWood LukeWood requested a review from fchollet June 20, 2022 01:22
fchollet
fchollet reviewed Jun 20, 2022
View reviewed changes
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! We should fix the image links.

guides/md/keras_cv/cut_mix_mix_up_and_rand_augment.md Outdated Show resolved Hide resolved
guides/md/keras_cv/cut_mix_mix_up_and_rand_augment.md Outdated Show resolved Hide resolved
@LukeWood
Copy link
Contributor Author

@fchollet all done

fchollet
fchollet approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I'll take a look at fixing KerasCV guide generation going forward.

@fchollet fchollet merged commit 49a1647 into keras-team:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchollet fchollet fchollet approved these changes

@MarkDaoust MarkDaoust Awaiting requested review from MarkDaoust MarkDaoust is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LukeWood @fchollet