-
Notifications
You must be signed in to change notification settings - Fork 19.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ResNeSt to keras.applications #15816
Comments
@innat Please refer this implementation (https://github.com/RichardXiao13/TensorFlow-ResNets). |
@dathudeptrai no, it's a 3rd party implementation and comparatively much better tf-implementation is already mentioned above. |
@innat The implementation I mentioned above has almost the same structure and coding style as the models in tf.keras.applications |
@dathudeptrai you're missing the point. I'm not looking for model implementation. Please read the first post. |
Triage note: We'll consider this once KerasCV is ready which we believe is a better place for the application to live. |
@rchao is there any possibility that all the models under |
@LukeWood do you have an answer to the |
if this is referring to: I believe that the answer to this is that in the long term: yes. In the short/mid term: probably no as it would break many users. The code of applications will likely exist in both locations for a period of time, with some small differences (i.e. defaulting the weights argument to None for applications instead of |
I'd personally be in favor of including this in KerasCV instead of keras.applications. This would allow us to avoid duplicating some code. @fchollet may have some thoughts here as to where the best place to contribute this in the near term would be. |
System information.
TensorFlow version (you are using): 2.7
Are you willing to contribute it (Yes/No): No
Describe the feature and the current behavior/state.
Requesting to add the following model -
3rd party code:
Will this change the current api? How?
Yes.
Who will benefit from this feature?
TensorFlow/Keras users.
(It's better to have it in KerasCV`).
The text was updated successfully, but these errors were encountered: