Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ResNeSt to keras.applications #15816

Closed
innat opened this issue Dec 20, 2021 · 10 comments
Closed

Add ResNeSt to keras.applications #15816

innat opened this issue Dec 20, 2021 · 10 comments
Assignees
Labels
type:feature The user is asking for a new feature.

Comments

@innat
Copy link

innat commented Dec 20, 2021

System information.

TensorFlow version (you are using): 2.7
Are you willing to contribute it (Yes/No): No

Describe the feature and the current behavior/state.

Requesting to add the following model -

3rd party code:

Will this change the current api? How?
Yes.

tensorflow.keras.applications.ResNeSt50
tensorflow.keras.applications.ResNeSt101
tensorflow.keras.applications.ResNeSt200
tensorflow.keras.applications.ResNeSt269

Who will benefit from this feature?
TensorFlow/Keras users.

(It's better to have it in KerasCV`).

@innat innat added the type:feature The user is asking for a new feature. label Dec 20, 2021
@chunduriv chunduriv self-assigned this Dec 20, 2021
@dathudeptrai
Copy link

@innat Please refer this implementation (https://github.com/RichardXiao13/TensorFlow-ResNets).

@innat
Copy link
Author

innat commented Dec 20, 2021

@dathudeptrai no, it's a 3rd party implementation and comparatively much better tf-implementation is already mentioned above.

@dathudeptrai
Copy link

@innat The implementation I mentioned above has almost the same structure and coding style as the models in tf.keras.applications

@innat
Copy link
Author

innat commented Dec 20, 2021

@dathudeptrai you're missing the point. I'm not looking for model implementation. Please read the first post.

@sachinprasadhs sachinprasadhs added the keras-team-review-pending Pending review by a Keras team member. label Dec 22, 2021
@rchao
Copy link
Contributor

rchao commented Dec 23, 2021

Triage note: We'll consider this once KerasCV is ready which we believe is a better place for the application to live.

@rchao rchao added Contributions welcome and removed keras-team-review-pending Pending review by a Keras team member. labels Dec 23, 2021
@innat
Copy link
Author

innat commented Jan 8, 2022

@rchao is there any possibility that all the models under keras.applicaitons will move to the keras-cv project?

@innat
Copy link
Author

innat commented Jan 10, 2022

@QiaoranC @RichardXiao13

@rchao
Copy link
Contributor

rchao commented Jan 13, 2022

@LukeWood do you have an answer to the keras-cv question?

@LukeWood
Copy link
Contributor

@LukeWood do you have an answer to the keras-cv question?

if this is referring to:
"@rchao is there any possibility that all the models under keras.applicaitons will move to the keras-cv project?"

I believe that the answer to this is that in the long term: yes. In the short/mid term: probably no as it would break many users.

The code of applications will likely exist in both locations for a period of time, with some small differences (i.e. defaulting the weights argument to None for applications instead of imagenet)

@LukeWood
Copy link
Contributor

I'd personally be in favor of including this in KerasCV instead of keras.applications. This would allow us to avoid duplicating some code. @fchollet may have some thoughts here as to where the best place to contribute this in the near term would be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature The user is asking for a new feature.
Projects
None yet
Development

No branches or pull requests

6 participants