Gracefully handle legacy Sequential configs #11280
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In a recent change to Keras (#11133) incorporated in 2.2.3,
name
was added to the Sequential config. From the release notes:However, Keras now raises an
UnboundLocalError
exception whenever loading a legacy configuration file. Infrom_config
,name
can be undefined if this variable is not present in the config, and in line 298 of the modified file, is used bymodel = cls(name=name)
.I modified the code such that legacy configs still load, but throws a warning. Maybe a different behavior is desired, but Keras, in my opinion, shouldn't crash like this (especially without any warnings).
Related Issues
#11133
PR Overview