Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed EfficientNetV2's MBConvBlock output phase. #17364

Conversation

sebastian-sz
Copy link
Contributor

Fixes keras-team/tf-keras#329

Unindents output phase of MBConvBlock so that it is applied regardless of SE ratio.

To my knowledge, when inspecting the EfficientNetV2's configs, all MBConvBlocks use SE block part so the models and weights should be unchanged.

@fchollet
Copy link
Member

Thanks for the PR. What validation accuracy do you see with the modified model on the imagenet test set?

CC @ianstenbit

@sebastian-sz
Copy link
Contributor Author

@fchollet I did not run Imagenet evaluation as I suspect the models are unchanged. For all variants, after fix:

  1. The existing weights load without issue.
  2. If running inference on the same image, these models output the same values as the ones in tf-nightly.

gist I used for comparison.

@ianstenbit
Copy link
Contributor

Thanks Sebastian and Francois -- looks like this fix will also need to be made in KerasCV's EfficientNetV2 (and it will be in keras-team/keras-cv#1146)

@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Dec 21, 2022
@gbaned gbaned requested a review from fchollet December 21, 2022 06:49
@google-ml-butler google-ml-butler bot added the keras-team-review-pending Pending review by a Keras team member. label Dec 21, 2022
@haifeng-jin
Copy link
Member

haifeng-jin commented Dec 22, 2022

Pending on another reply from @fchollet .
Hold till 01/09/2023 to add the pending label again if no response.

@haifeng-jin haifeng-jin removed the keras-team-review-pending Pending review by a Keras team member. label Dec 22, 2022
@gbaned gbaned added type:docs Need to modify the documentation and removed type:docs Need to modify the documentation labels Dec 22, 2022
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Dec 27, 2022
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Dec 27, 2022
@gbaned gbaned added ready to pull Ready to be merged into the codebase and removed ready to pull Ready to be merged into the codebase labels Jan 4, 2023
@copybara-service copybara-service bot merged commit 16bc9f8 into keras-team:master Jan 4, 2023
PR Queue automation moved this from Approved by Reviewer to Merged Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to pull Ready to be merged into the codebase size:S
Projects
PR Queue
Merged
Development

Successfully merging this pull request may close these issues.

Error in EfficientNet V2 MBConvBlock
6 participants