Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements and code refactoring in backend.py #17746

Merged

Conversation

Frightera
Copy link
Contributor

Small changes in backend.py, some of were discussed in the PR #17651

@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Mar 31, 2023
@gbaned gbaned requested a review from qlzh727 March 31, 2023 18:37
@google-ml-butler google-ml-butler bot added the keras-team-review-pending Pending review by a Keras team member. label Mar 31, 2023
keras/backend.py Outdated Show resolved Hide resolved
PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Apr 4, 2023
@Frightera Frightera requested a review from qlzh727 April 4, 2023 21:04
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Apr 4, 2023
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Apr 4, 2023
copybara-service bot pushed a commit that referenced this pull request Apr 5, 2023
Imported from GitHub PR #17746

Small changes in backend.py, some of were discussed in the PR #17651
Copybara import of the project:

--
0f89165 by Kaan Bıçakcı <kaan.dvlpr@gmail.com>:

Small fixes on focal losses and cat.crossentropy

--
3c193de by Kaan Bıçakcı <kaan.dvlpr@gmail.com>:

Fix linting and sigmoid func

--
b87b656 by Kaan Bıçakcı <kaan.dvlpr@gmail.com>:

Revert the redirection of the internal function

Merging this change closes #17746

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17746 from Frightera:frightera_small_loss_fixes b87b656
PiperOrigin-RevId: 522179031
@haifeng-jin
Copy link
Contributor

The copybara created CL needs to be synced before submission. What do we do in this case? @qlzh727

@qlzh727
Copy link
Member

qlzh727 commented Apr 6, 2023

The copybara created CL needs to be synced before submission. What do we do in this case? @qlzh727

You can patch the cl, sync it and then submit.

@haifeng-jin haifeng-jin self-assigned this Apr 6, 2023
copybara-service bot pushed a commit that referenced this pull request Apr 6, 2023
Imported from GitHub PR #17746

Small changes in backend.py, some of were discussed in the PR #17651
Copybara import of the project:

--
0f89165 by Kaan Bıçakcı <kaan.dvlpr@gmail.com>:

Small fixes on focal losses and cat.crossentropy

--
3c193de by Kaan Bıçakcı <kaan.dvlpr@gmail.com>:

Fix linting and sigmoid func

--
b87b656 by Kaan Bıçakcı <kaan.dvlpr@gmail.com>:

Revert the redirection of the internal function

Merging this change closes #17746

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17746 from Frightera:frightera_small_loss_fixes b87b656
PiperOrigin-RevId: 522179031
copybara-service bot pushed a commit that referenced this pull request Apr 6, 2023
Imported from GitHub PR #17746

Small changes in backend.py, some of were discussed in the PR #17651
Copybara import of the project:

--
0f89165 by Kaan Bıçakcı <kaan.dvlpr@gmail.com>:

Small fixes on focal losses and cat.crossentropy

--
3c193de by Kaan Bıçakcı <kaan.dvlpr@gmail.com>:

Fix linting and sigmoid func

--
b87b656 by Kaan Bıçakcı <kaan.dvlpr@gmail.com>:

Revert the redirection of the internal function

Merging this change closes #17746

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17746 from Frightera:frightera_small_loss_fixes b87b656
PiperOrigin-RevId: 522179031
@copybara-service copybara-service bot merged commit 4557f32 into keras-team:master Apr 6, 2023
PR Queue automation moved this from Approved by Reviewer to Merged Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keras-team-review-pending Pending review by a Keras team member. ready to pull Ready to be merged into the codebase size:S
Projects
PR Queue
Merged
Development

Successfully merging this pull request may close these issues.

None yet

5 participants