Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keras/layers/convolutional/conv3d.py] Standardise docstring usage of "Default to" #17796

Conversation

SamuelMarks
Copy link
Contributor

This is one of many PRs. Discussion + request to split into multiple PRs @ #17748

@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Apr 4, 2023
@gbaned gbaned requested a review from qlzh727 April 4, 2023 16:47
@google-ml-butler google-ml-butler bot added the keras-team-review-pending Pending review by a Keras team member. label Apr 4, 2023
Copy link
Member

@qlzh727 qlzh727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint error.

PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Apr 4, 2023
@SamuelMarks
Copy link
Contributor Author

Please fix the lint error.

Fixed

keras/layers/convolutional/conv3d.py Outdated Show resolved Hide resolved
PR Queue automation moved this from Reviewer Requested Changes to Approved by Reviewer Apr 4, 2023
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Apr 4, 2023
copybara-service bot pushed a commit that referenced this pull request Apr 5, 2023
…ng usage of "Default to"

Imported from GitHub PR #17796

This is one of many PRs. Discussion + request to split into multiple PRs @ #17748
Copybara import of the project:

--
12b9594 by Samuel Marks <807580+SamuelMarks@users.noreply.github.com>:

[keras/layers/convolutional/conv3d.py] Standardise docstring usage of "Defaults to"

--
0e61e2c by Samuel Marks <807580+SamuelMarks@users.noreply.github.com>:

[keras/layers/convolutional/conv3d.py] Fix E501

--
09b09d2 by Samuel Marks <807580+SamuelMarks@users.noreply.github.com>:

[keras/layers/convolutional/conv3d.py] Use `channels_last` for Conv3D

Merging this change closes #17796

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17796 from SamuelMarks:keras.layers.convolutional.conv3d-defaults-to 09b09d2
PiperOrigin-RevId: 522171702
copybara-service bot pushed a commit that referenced this pull request Apr 5, 2023
…ng usage of "Default to"

Imported from GitHub PR #17796

This is one of many PRs. Discussion + request to split into multiple PRs @ #17748
Copybara import of the project:

--
12b9594 by Samuel Marks <807580+SamuelMarks@users.noreply.github.com>:

[keras/layers/convolutional/conv3d.py] Standardise docstring usage of "Defaults to"

--
0e61e2c by Samuel Marks <807580+SamuelMarks@users.noreply.github.com>:

[keras/layers/convolutional/conv3d.py] Fix E501

--
09b09d2 by Samuel Marks <807580+SamuelMarks@users.noreply.github.com>:

[keras/layers/convolutional/conv3d.py] Use `channels_last` for Conv3D

Merging this change closes #17796

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17796 from SamuelMarks:keras.layers.convolutional.conv3d-defaults-to 09b09d2
PiperOrigin-RevId: 522171702
@copybara-service copybara-service bot merged commit 2c17862 into keras-team:master Apr 6, 2023
PR Queue automation moved this from Approved by Reviewer to Merged Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keras-team-review-pending Pending review by a Keras team member. ready to pull Ready to be merged into the codebase size:S
Projects
PR Queue
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants