Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keras/feature_column] Standardise docstring usage of "Default to" #17958

Conversation

SamuelMarks
Copy link
Contributor

This is one of many PRs. Discussion + request to split into multiple PRs @ #17748

…_feature_column.py] Standardise docstring usage of "Default to"
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Apr 13, 2023
@gbaned gbaned requested a review from haifeng-jin April 13, 2023 05:49
@google-ml-butler google-ml-butler bot added the keras-team-review-pending Pending review by a Keras team member. label Apr 13, 2023
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Apr 22, 2023
@haifeng-jin haifeng-jin removed the keras-team-review-pending Pending review by a Keras team member. label Apr 22, 2023
@gbaned gbaned added ready to pull Ready to be merged into the codebase and removed ready to pull Ready to be merged into the codebase labels May 9, 2023
copybara-service bot pushed a commit that referenced this pull request May 9, 2023
…ault to"

Imported from GitHub PR #17958

This is one of many PRs. Discussion + request to split into multiple PRs @ #17748
Copybara import of the project:

--
c7157c0 by Samuel Marks <807580+SamuelMarks@users.noreply.github.com>:

[keras/feature_column/dense_features.py,keras/feature_column/sequence_feature_column.py] Standardise docstring usage of "Default to"

Merging this change closes #17958

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17958 from SamuelMarks:keras.feature_column-defaults-to c7157c0
PiperOrigin-RevId: 530510337
@gbaned gbaned added ready to pull Ready to be merged into the codebase and removed ready to pull Ready to be merged into the codebase labels May 25, 2023
copybara-service bot pushed a commit that referenced this pull request May 31, 2023
…ault to"

Imported from GitHub PR #17958

This is one of many PRs. Discussion + request to split into multiple PRs @ #17748
Copybara import of the project:

--
c7157c0 by Samuel Marks <807580+SamuelMarks@users.noreply.github.com>:

[keras/feature_column/dense_features.py,keras/feature_column/sequence_feature_column.py] Standardise docstring usage of "Default to"

Merging this change closes #17958

FUTURE_COPYBARA_INTEGRATE_REVIEW=#17958 from SamuelMarks:keras.feature_column-defaults-to c7157c0
PiperOrigin-RevId: 535275621
@copybara-service copybara-service bot merged commit 502a296 into keras-team:master May 31, 2023
7 checks passed
PR Queue automation moved this from Assigned Reviewer to Merged May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to pull Ready to be merged into the codebase size:S
Projects
PR Queue
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants