Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update indentation level - activations.py #18036

Merged

Conversation

Frightera
Copy link
Contributor

This PR changes the indentation level of the docstrings to 4 spaces.

@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Apr 24, 2023
@gbaned gbaned requested a review from haifeng-jin April 24, 2023 04:14
@google-ml-butler google-ml-butler bot added the keras-team-review-pending Pending review by a Keras team member. label Apr 24, 2023
Copy link
Member

@haifeng-jin haifeng-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

keras/activations.py Outdated Show resolved Hide resolved
keras/activations.py Outdated Show resolved Hide resolved
keras/activations.py Outdated Show resolved Hide resolved
PR Queue automation moved this from Assigned Reviewer to Reviewer Requested Changes Apr 24, 2023
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Apr 24, 2023
@mihirparadkar mihirparadkar removed the keras-team-review-pending Pending review by a Keras team member. label Apr 26, 2023
copybara-service bot pushed a commit that referenced this pull request Apr 26, 2023
Imported from GitHub PR #18036

This PR changes the indentation level of the docstrings to 4 spaces.
Copybara import of the project:

--
251355f by Kaan Bıçakcı <kaan.dvlpr@gmail.com>:

Migrate docstring to 4 indents

--
49af17f by Kaan Bıçakcı <kaan.dvlpr@gmail.com>:

Fix formatting (1 char)

--
abec420 by Kaan Bıçakcı <kaan.dvlpr@gmail.com>:

Fix broken link

--
263660d by Kaan Bıçakcı <46622558+Frightera@users.noreply.github.com>:

Address comments from the review.

Merging this change closes #18036

FUTURE_COPYBARA_INTEGRATE_REVIEW=#18036 from Frightera:migrate_activations_docstring 263660d
PiperOrigin-RevId: 526664672
@google-ml-butler google-ml-butler bot removed the ready to pull Ready to be merged into the codebase label May 2, 2023
@Frightera Frightera requested a review from haifeng-jin May 2, 2023 20:00
@gbaned gbaned added the keras-team-review-pending Pending review by a Keras team member. label May 4, 2023
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels May 4, 2023
copybara-service bot pushed a commit that referenced this pull request May 4, 2023
Imported from GitHub PR #18036

This PR changes the indentation level of the docstrings to 4 spaces.
Copybara import of the project:

--
251355f by Kaan Bıçakcı <kaan.dvlpr@gmail.com>:

Migrate docstring to 4 indents

--
49af17f by Kaan Bıçakcı <kaan.dvlpr@gmail.com>:

Fix formatting (1 char)

--
abec420 by Kaan Bıçakcı <kaan.dvlpr@gmail.com>:

Fix broken link

--
263660d by Kaan Bıçakcı <46622558+Frightera@users.noreply.github.com>:

Address comments from the review.

Merging this change closes #18036

FUTURE_COPYBARA_INTEGRATE_REVIEW=#18036 from Frightera:migrate_activations_docstring 78e487b
PiperOrigin-RevId: 526664672
@Frightera
Copy link
Contributor Author

@gbaned Any idea why copybara closed the PR without merging it?

@divyashreepathihalli divyashreepathihalli removed the keras-team-review-pending Pending review by a Keras team member. label May 5, 2023
@gbaned
Copy link
Collaborator

gbaned commented May 9, 2023

@gbaned Any idea why copybara closed the PR without merging it?

Hi @Frightera I can see this PR is still open, can you please provide PR which is closed by copybara without merging it. Thank you!

@Frightera
Copy link
Contributor Author

Frightera commented May 9, 2023

Hi @gbaned I meant #18060

@gbaned
Copy link
Collaborator

gbaned commented May 25, 2023

Hi @gbaned I meant #18060

Hi @Frightera Sorry for the delay. PR #18060 has been closed by copybara as part of internal process. Thank you!

@gbaned gbaned added ready to pull Ready to be merged into the codebase and removed ready to pull Ready to be merged into the codebase labels May 25, 2023
copybara-service bot pushed a commit that referenced this pull request May 25, 2023
Imported from GitHub PR #18036

This PR changes the indentation level of the docstrings to 4 spaces.
Copybara import of the project:

--
251355f by Kaan Bıçakcı <kaan.dvlpr@gmail.com>:

Migrate docstring to 4 indents

--
49af17f by Kaan Bıçakcı <kaan.dvlpr@gmail.com>:

Fix formatting (1 char)

--
abec420 by Kaan Bıçakcı <kaan.dvlpr@gmail.com>:

Fix broken link

--
263660d by Kaan Bıçakcı <46622558+Frightera@users.noreply.github.com>:

Address comments from the review.

Merging this change closes #18036

FUTURE_COPYBARA_INTEGRATE_REVIEW=#18036 from Frightera:migrate_activations_docstring 78e487b
PiperOrigin-RevId: 535275542
@copybara-service copybara-service bot merged commit 8a181ba into keras-team:master May 31, 2023
7 checks passed
PR Queue automation moved this from Reviewer Requested Changes to Merged May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to pull Ready to be merged into the codebase size:M
Projects
PR Queue
Merged
Development

Successfully merging this pull request may close these issues.

None yet

6 participants