Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated read.me #18226

Merged
merged 2 commits into from Jun 16, 2023
Merged

updated read.me #18226

merged 2 commits into from Jun 16, 2023

Conversation

VaishnaviMudaliar
Copy link
Contributor

No description provided.

@google-cla
Copy link

google-cla bot commented Jun 14, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sachinprasadhs sachinprasadhs added the keras-team-review-pending Pending review by a Keras team member. label Jun 14, 2023
@gbaned
Copy link
Collaborator

gbaned commented Jun 15, 2023

Hi @VaishnaviMudaliar Thank you for your contribution.

Please don't use "add file"/"update file"/"fix file"/etc. commit messages. These are hard to reason about when looking at the history of the file/repository. Instead, please write explanatory git commit messages.

The commit message is also the title of the PR if the PR has only one commit. It is thus twice important to have commit messages that are relevant, as PRs would be easier to understand and easier to analyze in search results.

For how to write good quality git commit messages, please consult https://cbea.ms/git-commit/

@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Jun 15, 2023
@gbaned gbaned requested a review from fchollet June 15, 2023 05:44
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Jun 15, 2023
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jun 15, 2023
copybara-service bot pushed a commit that referenced this pull request Jun 16, 2023
Imported from GitHub PR #18226

Copybara import of the project:

Merging this change closes #18226

FUTURE_COPYBARA_INTEGRATE_REVIEW=#18226 from VaishnaviMudaliar:master bedd434
PiperOrigin-RevId: 540958695
@copybara-service copybara-service bot merged commit 8e63b2f into keras-team:master Jun 16, 2023
5 of 7 checks passed
PR Queue automation moved this from Approved by Reviewer to Merged Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review keras-team-review-pending Pending review by a Keras team member. ready to pull Ready to be merged into the codebase size:XS
Projects
PR Queue
Merged
Development

Successfully merging this pull request may close these issues.

None yet

5 participants