Fix legacy optimizer handling in compile_from_config().
#18492
Conversation
| if ( | ||
| hasattr(self, "optimizer") | ||
| # Exempt legacy optimizers. | ||
| and isinstance(self.optimizer, optimizer.Optimizer) |
There was a problem hiding this comment.
Is it every possible to pass an optimizer that isn't an Optimizer instance? Wouldn't that blow up?
There was a problem hiding this comment.
All custom optimizers that need to be built on deserialization must subclass from Optimizer afaik, and legacy optimizers (which do not) are exempted here because they do not have a corresponding build method.
Is there any edge case in particular you are referring to? The corresponding CL did not cause any TGP issues.
There was a problem hiding this comment.
Legacy optimizers simply don't exist in Keras 3, do they?
There was a problem hiding this comment.
This PR is actually for the Keras 2.15 release, so legacy optimizers still exist in this revision actually (merging into the cherrypick branch).
There was a problem hiding this comment.
Got it, I had not noticed this was in the 2.15 branch.
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
removed
awaiting review
ready to pull
Piper revision: 567432507
Github issues:
https://github.com/keras-team/keras/issues/18278
https://github.com/keras-team/keras/issues/18359