Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(preprocessing): resolve ValueError for ngrams tuple #19190

Merged

Conversation

mykolaskrynnyk
Copy link
Contributor

Resolves a deserialisation issue when ngrams is set to a tuple in TextVectorization layer. Closes #19180.

Copy link

google-cla bot commented Feb 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Resolves a deserialisation issue when `ngrams` is set to a tuple in `TextVectorization` layer. Closes keras-team#19180
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Please add a unit test (so we avoid breaking it in the future...)

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Feb 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c8700f4) 80.14% compared to head (a077958) 75.48%.
Report is 38 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19190      +/-   ##
==========================================
- Coverage   80.14%   75.48%   -4.67%     
==========================================
  Files         341      362      +21     
  Lines       36163    39049    +2886     
  Branches     7116     7564     +448     
==========================================
+ Hits        28982    29475     +493     
- Misses       5578     7948    +2370     
- Partials     1603     1626      +23     
Flag Coverage Δ
keras 75.33% <100.00%> (-4.66%) ⬇️
keras-jax 59.46% <0.00%> (-3.60%) ⬇️
keras-numpy 53.92% <0.00%> (-3.17%) ⬇️
keras-tensorflow 60.81% <100.00%> (-3.85%) ⬇️
keras-torch 60.08% <0.00%> (-3.79%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@google-ml-butler google-ml-butler bot removed the ready to pull Ready to be merged into the codebase label Feb 17, 2024
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Feb 17, 2024
@fchollet fchollet merged commit 7a0e670 into keras-team:master Feb 17, 2024
6 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Feb 17, 2024
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Feb 19, 2024
@mykolaskrynnyk mykolaskrynnyk deleted the fix/vectorization-ngrams-error branch March 10, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
PR Queue
Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

ValueError: ngrams when loading a model with a TextVectorization layer
5 participants