Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prints from image dataset from directory #19228

Conversation

EtiNL
Copy link
Contributor

@EtiNL EtiNL commented Feb 25, 2024

I added a verbose arg to index_directory function in utils/dataset_utils.py and to image_dataset_from_directory function in utils/image_dataset_utils.py to control/remove prints when using image_dataset_from_directory.

@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Feb 26, 2024
@gbaned gbaned requested a review from fchollet February 26, 2024 03:51
@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 75.51%. Comparing base (c8700f4) to head (0817213).
Report is 67 commits behind head on master.

Files Patch % Lines
keras/utils/dataset_utils.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19228      +/-   ##
==========================================
- Coverage   80.14%   75.51%   -4.63%     
==========================================
  Files         341      363      +22     
  Lines       36163    39232    +3069     
  Branches     7116     7586     +470     
==========================================
+ Hits        28982    29628     +646     
- Misses       5578     7968    +2390     
- Partials     1603     1636      +33     
Flag Coverage Δ
keras 75.37% <75.00%> (-4.62%) ⬇️
keras-jax 59.74% <75.00%> (-3.32%) ⬇️
keras-numpy 54.15% <75.00%> (-2.93%) ⬇️
keras-tensorflow 60.89% <75.00%> (-3.77%) ⬇️
keras-torch 60.37% <75.00%> (-3.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

PR Queue automation moved this from Assigned Reviewer to Approved by Reviewer Feb 26, 2024
@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Feb 26, 2024
@fchollet fchollet merged commit 065e3c8 into keras-team:master Feb 26, 2024
6 checks passed
PR Queue automation moved this from Approved by Reviewer to Merged Feb 26, 2024
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase kokoro:force-run labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
PR Queue
Merged
Development

Successfully merging this pull request may close these issues.

None yet

4 participants