Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add token to codecov #19312

Merged
merged 1 commit into from Mar 14, 2024
Merged

add token to codecov #19312

merged 1 commit into from Mar 14, 2024

Conversation

haifeng-jin
Copy link
Member

@haifeng-jin haifeng-jin commented Mar 14, 2024

Resolves #19264
We may need to add the secret to the repo if it is not there yet.
The tests running here are fine.
Let's merge it to see if it works on the master branch.

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.36%. Comparing base (c8700f4) to head (0c139a4).
Report is 98 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19312      +/-   ##
==========================================
- Coverage   80.14%   71.36%   -8.78%     
==========================================
  Files         341      366      +25     
  Lines       36163    40071    +3908     
  Branches     7116     7769     +653     
==========================================
- Hits        28982    28597     -385     
- Misses       5578     9842    +4264     
- Partials     1603     1632      +29     
Flag Coverage Δ
keras 71.25% <ø> (-8.74%) ⬇️
keras-jax ?
keras-numpy 54.46% <ø> (-2.63%) ⬇️
keras-tensorflow 61.37% <ø> (-3.28%) ⬇️
keras-torch 60.50% <ø> (-3.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Added it as a "Repository secret".

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Mar 14, 2024
@fchollet fchollet merged commit 0e40bde into keras-team:master Mar 14, 2024
12 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase kokoro:force-run labels Mar 14, 2024
@haifeng-jin haifeng-jin deleted the codecov branch March 15, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The master branch commit doesn't update in Codecov
4 participants