Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with using a callable as a learning rate #19484

Merged
merged 2 commits into from Apr 11, 2024

Conversation

kapoor1992
Copy link
Contributor

Closes #19411.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Apr 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.22%. Comparing base (6a9bc4c) to head (c2e07e7).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #19484   +/-   ##
=======================================
  Coverage   76.21%   76.22%           
=======================================
  Files         367      367           
  Lines       41066    41066           
  Branches     8018     8018           
=======================================
+ Hits        31298    31302    +4     
+ Misses       8055     8053    -2     
+ Partials     1713     1711    -2     
Flag Coverage Δ
keras 76.07% <100.00%> (+<0.01%) ⬆️
keras-jax 60.28% <100.00%> (+<0.01%) ⬆️
keras-numpy 54.20% <100.00%> (+<0.01%) ⬆️
keras-tensorflow 61.56% <100.00%> (+<0.01%) ⬆️
keras-torch 60.37% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fchollet fchollet merged commit 7caec08 into keras-team:master Apr 11, 2024
10 checks passed
@google-ml-butler google-ml-butler bot removed the ready to pull Ready to be merged into the codebase label Apr 11, 2024
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
PR Queue
Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

keras adamw optimizer failed with callable parameters in TensorFlow2.16
5 participants