Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented median(...) function. #19568

Merged
merged 2 commits into from Apr 20, 2024
Merged

Implemented median(...) function. #19568

merged 2 commits into from Apr 20, 2024

Conversation

hazemessamm
Copy link
Contributor

@hazemessamm hazemessamm commented Apr 20, 2024

Currently, MLX does not have a bultin median(...) function so I implemented it by using mx.sort(...) and mx.take(...).

@codecov-commenter
Copy link

codecov-commenter commented Apr 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (mlx@587b4c9). Click here to learn what that means.

Files Patch % Lines
keras/src/backend/mlx/numpy.py 0.00% 8 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             mlx   #19568   +/-   ##
======================================
  Coverage       ?   73.71%           
======================================
  Files          ?      506           
  Lines          ?    45809           
  Branches       ?     8466           
======================================
  Hits           ?    33768           
  Misses         ?    10329           
  Partials       ?     1712           
Flag Coverage Δ
keras 73.56% <0.00%> (?)
keras-jax 59.01% <0.00%> (?)
keras-numpy 53.33% <0.00%> (?)
keras-tensorflow 60.15% <0.00%> (?)
keras-torch 59.08% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Apr 20, 2024
@fchollet fchollet merged commit 1edc652 into keras-team:mlx Apr 20, 2024
8 of 9 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Apr 20, 2024
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Apr 22, 2024
@lkarthee lkarthee mentioned this pull request May 2, 2024
62 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
PR Queue
Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

4 participants