Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mlx - numpy fix scalar handling and skip float 64 tests #19613

Merged
merged 1 commit into from Apr 25, 2024

Conversation

lkarthee
Copy link
Contributor

No description provided.

@lkarthee lkarthee changed the base branch from master to mlx April 25, 2024 10:28
skip float64 tests
dont convert scalar to tensor if the mx api accepts it.
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (mlx@ba0c886). Click here to learn what that means.

Files Patch % Lines
keras/src/backend/mlx/numpy.py 0.00% 38 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             mlx   #19613   +/-   ##
======================================
  Coverage       ?   68.48%           
======================================
  Files          ?      506           
  Lines          ?    45935           
  Branches       ?     8496           
======================================
  Hits           ?    31457           
  Misses         ?    12829           
  Partials       ?     1649           
Flag Coverage Δ
keras 68.40% <0.00%> (?)
keras-jax 58.87% <0.00%> (?)
keras-numpy 53.19% <0.00%> (?)
keras-tensorflow 60.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Apr 25, 2024
@fchollet fchollet merged commit 722883a into keras-team:mlx Apr 25, 2024
4 of 7 checks passed
@google-ml-butler google-ml-butler bot removed ready to pull Ready to be merged into the codebase kokoro:force-run labels Apr 25, 2024
@lkarthee lkarthee deleted the numpy_fix branch April 25, 2024 18:05
@gbaned gbaned added this to Assigned Reviewer in PR Queue via automation Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
PR Queue
Assigned Reviewer
Development

Successfully merging this pull request may close these issues.

None yet

4 participants