Add name to MobileNetV3 to allow multiple instances in one model
#19695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #19695 +/- ##
==========================================
+ Coverage 78.52% 81.47% +2.95%
==========================================
Files 498 498
Lines 45699 45769 +70
Branches 8446 8456 +10
==========================================
+ Hits 35884 37292 +1408
+ Misses 8087 6578 -1509
- Partials 1728 1899 +171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jeffcarp
force-pushed
the
mobilenetv3-duplicate-names-19689
branch
from
32e4816
to
b44ade6
Compare
|
Here's my change: 2b7120b Please apply the same for MobileNet models 👍 |
jeffcarp
force-pushed
the
mobilenetv3-duplicate-names-19689
branch
from
b44ade6
to
b0f4708
Compare
jeffcarp
force-pushed
the
mobilenetv3-duplicate-names-19689
branch
from
b0f4708
to
14caa78
Compare
jeffcarp
changed the title
name to MobileNetV3 to allow multiple instances in one model
fchollet
approved these changes
May 12, 2024
google-ml-butler
bot
added
kokoro:force-run
ready to pull
google-ml-butler
bot
removed
ready to pull
jeffcarp
added a commit
to jeffcarp/keras
that referenced
this pull request
May 13, 2024
Followup from keras-team#19695 and 2b7120b.
|
Sent #19712 for V1 and V2. |
jeffcarp
added a commit
to jeffcarp/keras
that referenced
this pull request
May 13, 2024
Followup from keras-team#19695 and 2b7120b.
fchollet
pushed a commit
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19689
I opted to add a
namearg to fix the issue since it's a similar pattern in otherkeras.applicationsmodels (updated: see conversation below). An alternative way is to usekeras.src.utils.naming.uniquifyinternally.