Fix Adam saving #8804
Merged
Fix Adam saving #8804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in model saving caused by PR #8693.
K.batch_get_valuedoes not supportNonevalues. An error occurs when it is called insave_modelto getAdam(amsgrad=False)optimizer weights (on all 3 backends).Fix it by creating size-1 zero tensors instead of
None. Cannot use size-0 tensors becauseK.batch_set_valuewould fail on size-0 tensors during model loading.Also changed a test in test_model_saving.py (switching from
RMSproptoAdam) to cover this case.