Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added decoupled weight decay for optimizers #9189

Closed
wants to merge 2 commits into from

Conversation

kashif
Copy link
Contributor

@kashif kashif commented Jan 25, 2018

From the paper: "Fixing Weight Decay Regularization in Adam"

@kashif kashif changed the title decoupled weight decay for optimizers Added decoupled weight decay for optimizers Jan 25, 2018
@fchollet
Copy link
Member

Thanks for the PR!

I think we should at least wait for the paper to be out of peer review (the ICLR 2018 results should be out soon) before making a permanent Keras API change. We've been beaten by this several times in the past.

In the meantime, people who want this feature can use this PR as a reference to add it to an existing optimizer.

@fchollet fchollet closed this Jan 26, 2018
@ozabluda
Copy link
Contributor

beaten => bitten. AKA "subscribe".

@AvantiShri
Copy link

Fast.ai is making a big deal about being the only deep learning framework with this fix: http://www.fast.ai/2018/07/02/adam-weight-decay/

“the only deep learning framework that implemented the fix was fastai, using code written by Sylvain. Without broad framework availability, day-to-day practitioners were stuck with the old, “broken” Adam.”

@kashif
Copy link
Contributor Author

kashif commented Jul 3, 2018

@AvantiShri funny... chainer has it for a while already... my pytorch PR is also pending since beginning of the year... anyways, would @fchollet you be ok with a flag that switches between the l2 reg. and decay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants