Return identities.Claims from ClaimsFrom #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keratin#18 introduced support for ClaimsFrom, returning the default verified claims in the identity token. That PR, however, failed to consider that the identity token augments the default claims with an AuthTime (`auth_time`) which supports password confirmation actions, e.g., https://keratin.github.io/authn-server/#/guide-confirm-password.
cainlevy
approved these changes
Jun 14, 2022
|
Any blockers to merging this, @cainlevy? Would be nice to get this in a new release within the next couple weeks. Thank you. |
|
Thanks for the reminder! I simply got mixed up with my work habits. |
AlexCuse
added a commit
to AlexCuse/authn-go
that referenced
this pull request
Dec 13, 2022
Through use of identities.Claims from github.com/keratin/authn-server, PR keratin#21 forces users of the client to build with CGO enabled. This embeds the new type (which really just wraps the Claims type from gopkg.in/square/go-jose.v2) directly in the client to eliminate this requirement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18 introduced support for
ClaimsFrom, returning the default verified claims in the identity
token. That PR, however, failed to consider that the identity token
augments the default claims with an AuthTime (
auth_time) whichsupports password confirmation actions, e.g.,
https://keratin.github.io/authn-server/#/guide-confirm-password.
Closes #20.