Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add TOTP MFA functions #60

Merged
merged 6 commits into from
Jan 31, 2024
Merged

feat: add TOTP MFA functions #60

merged 6 commits into from
Jan 31, 2024

Conversation

AlexCuse
Copy link
Contributor

@AlexCuse AlexCuse commented Nov 23, 2023

  • add OTP related arguments to login / session token login
  • add new functions for OTP related server calls
  • document new functions and note server version required

@AlexCuse AlexCuse marked this pull request as ready for review December 12, 2023 22:00
@AlexCuse
Copy link
Contributor Author

@cainlevy I think this should be good to go - I am not including the AMR claim on the JS side since we aren't in great shape to verify. Seems similar to what we did with the session ID and some of the other custom claims.

@AlexCuse
Copy link
Contributor Author

This has some tests that should be failing (otp needs to be string | undefined). Not sure why CI came up clean. Going to try and add tests over the next week and a half or so.

@AlexCuse
Copy link
Contributor Author

AlexCuse commented Jan 20, 2024

@cainlevy mind another look at this? I got down a bit of a rabbit hole trying to update MSW and ran into issues trying to use typescript dependencies with jest. Decided to give up and came back to fix the credentials type and add some tests using the old version.

@AlexCuse AlexCuse mentioned this pull request Jan 23, 2024
@AlexCuse AlexCuse merged commit 0f6a22c into keratin:main Jan 31, 2024
@AlexCuse AlexCuse deleted the mfa branch January 31, 2024 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants