Allow same-origin requests #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cainlevy
requested changes
Jun 1, 2019
Origin header is missing. Closes keratin#67. Signed-off-by: Silas Davis <silas@monax.io>
silasdavis
force-pushed
the
allow-same-origin
branch
from
9c4566b
to
84d931e
Compare
|
Pulled out some assertions from loop and added to changelog |
cainlevy
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By infering domain from Referer header iff Origin header is missing.
Some browser (e.g. Firefox) do not send Origin header for same origin requests. Since we implicitly rely on browser to add the header for any cross-origins requests we ought to similarly be able to infer that it is not a cross-origin request when the Origin header is missing. This encodes that assumption and as suggested in #67 uses the Referer header to observe the same origin in question. We fail if the Referer header is missing and we only ever consider the Referer header if the Origin header is missing.
Closes #67.
Signed-off-by: Silas Davis silas@monax.io