Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: bump go-redis (v6.15.2 => v8.11.4) #191

Merged
merged 1 commit into from
Dec 31, 2021

Conversation

jeffreylo
Copy link
Contributor

@jeffreylo jeffreylo commented Dec 30, 2021

This patch bumps the go-redis library to v8, which resolves an issue when authn-server is configured with a non-default Redis user.

v8 notably introduces the use of the stdlib's context package to its client functions. This patch sidesteps a decision on whether the blob and refresh token stores should also be context-aware by using context.TODO() as needed.

Closes #186.

This patch bumps the go-redis library to v8, which resolves an issue
when authn-server is configured with a non-default Redis user.

v8 notably introduces the use of the stdlib's context package to its
client functions. This patch sidesteps a decision on whether the blob
and refresh token stores should also be context-aware by using
`context.TODO()` as needed.

Closes keratin#186.
@cainlevy cainlevy merged commit ef558a0 into keratin:master Dec 31, 2021
@jeffreylo jeffreylo deleted the jlo/goredis-v8 branch December 31, 2021 20:17
cainlevy added a commit that referenced this pull request Dec 31, 2021
@cainlevy
Copy link
Member

v1.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-default Redis user does not work due to outdated version of go-redis library
2 participants