fix for archiving more than one account ever #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sometimes teardown can fail and leave artifacts in the database
this defeats the uniqueness constraint while still removing personal information. the random hash is then removed when fetching a record so that there's no confusion in the app. this approach seems better than making the field nullable and creating a vector for new and fun go panics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the uniqueness constraint on the database would complain when a second account was deleted. This changeset generates random username placeholders when archiving.
There is a very small chance of collision in applications where the username is not validated as an email. This remote possibility seems better than the likely bugs and follow-on effects that could result from adding nil-able usernames into the data model.