Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix postgres connection leak #60

Merged
merged 3 commits into from
Aug 1, 2018
Merged

Fix postgres connection leak #60

merged 3 commits into from
Aug 1, 2018

Conversation

shashankmehra
Copy link

Also assert connection stats where ever supported.

@coveralls
Copy link

coveralls commented Aug 1, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.009%) to 73.15% when pulling ef571df on shashankmehra:fix_postgres_connleak into 808901c on keratin:master.

cainlevy
cainlevy approved these changes Aug 1, 2018
View reviewed changes
Copy link
Member

@cainlevy cainlevy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. thanks for adding tests!

@cainlevy cainlevy merged commit 2f08893 into keratin:master Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cainlevy cainlevy cainlevy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shashankmehra @coveralls @cainlevy