Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video thumbnail is now a fixed height, not width. #59

Closed
wants to merge 2 commits into from
Closed

Video thumbnail is now a fixed height, not width. #59

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 10, 2018

I noticed that when opening some videos the thumbnail created makes the window too big to display fully on-screen, in my case this meant I couldn't then click on play to 'cast the video. Having looked at the command-line passed to ffmpeg I realised that you were creating a thumbnail of a fixed width, with an auto-sized height, I've just swapped the command-line arguments so that the thumbnail is a fixed height with an auto-sized width.

The current fixed height value works for me, obviously you can tweak it further to suit.

Also now changed the seek position for the thumbnail, since some of videos that I want to 'cast weren't the defined 27 seconds long.

@keredson
Copy link
Owner

what screen resolution are you using?

@ghost
Copy link
Author

ghost commented Jun 11, 2018

@keredson I'm using a laptop with screen resolution: 1366x768 and found that if I tried to play some videos originally recorded in portrait orientation, the thumbnail would sometimes cause the window to extend below the visible desktop area, even moving the window up to the top of the screen left me unable to click on the media buttons. Also noticed that I couldn't resize the window. My first thought was to try to add accelerators to the media buttons, but then having looked at the code, as per the PR I just made ffmpeg produce a fixed height / variable width thumbnail, rather than a fixed width / variable height one.

The other tweak was just to grab the thumbnail earlier in the stream.

@keredson
Copy link
Owner

i appreciate the PR, but i like the constant width / variable height design, rather than the other way around. the rest if the UI is designed to fit a specific width. this PR will create weird gaps on the left/right side of the view window.

that being said, we should prob. have a max-height feature somewhere. 768 seems a reasonable value. if you wish to submit another PR for that i'd be game. i opened #61 to track.

@keredson keredson closed this Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant