Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use these Font Awesome 5 working names :) #30

Closed
username1290 opened this issue Jan 22, 2018 · 10 comments
Closed

Use these Font Awesome 5 working names :) #30

username1290 opened this issue Jan 22, 2018 · 10 comments

Comments

@username1290
Copy link

Just in case anyone needs the right names for the SVG install to work:

Font Awesome 5 Free
Font Awesome 5 Free Solid
Font Awesome 5 Brands

Just make sure the SVG font id and font-face font-family have these names
馃槃

@keremciu
Copy link
Owner

yep I made a video about it, I talked with them about pro fonts, I will publish a new version for the plugin

#25

@Animalejourbano
Copy link

It works also for pro fonts. I've used the following names and they work grate! Thanks a lot @keremciu for your work:
Font Awesome 5 Pro Light
Font Awesome 5 Pro
Font Awesome 5 Pro Solid

@keremciu
Copy link
Owner

keremciu commented Feb 1, 2018

@Animalejourbano oh so nice man! you know the problem font-ids and font-family names are different, can you give me a list font-ids and font-families for pro fonts?

I will just add them here:
https://github.com/keremciu/sketch-iconfont/blob/master/iconfont.sketchplugin/Contents/Sketch/const/import.js#L17

then when a user add that font, there will not be a problem, if you'd like to contribute you can send a PR about it!

@Animalejourbano
Copy link

Animalejourbano commented Feb 2, 2018

There is a problem with that, because all pro fonts have the same id, which is "fontawesome-pro" . At least in the 5.0.4 version
The difference between each font is given by the "font-face" and "font-weight" attributes of the "font-face" element.

<font-face font-family="Font Awesome 5 Pro" font-weight="300" font-style="Light" /> <font-face font-family="Font Awesome 5 Pro" font-weight="400" font-style="Regular" /> <font-face font-family="Font Awesome 5 Pro" font-weight="900" font-style="Solid" />

@steveharman
Copy link

steveharman commented Mar 2, 2018

Great stuff @keremciu ! I'm up and running with Font Awesome Pro 5.0.6 (current at time of writing) Light, Regular & Solid following the video and naming convention below:

Font Awesome 5 Pro Light
Font Awesome 5 Pro Regular
Font Awesome 5 Pro Solid

iconfont

Only small issue seems to be with the "Brands" font that comes with FA Pro. Its name details taken from the SVG appear to be:

 <font id="Font Awesome 5 Pro Brands" horiz-adv-x="640.4">
    <font-face font-family="Font Awesome 5 Pro Brands"
      units-per-em="512" ascent="448"
      descent="64"
      font-weight="400"
      font-style="Regular" />

How would we include support for using Brands in the Icon Font plugin please?

Thanks,

Steve

@frankparadiso
Copy link

frankparadiso commented Jul 3, 2018

I'm using:
<font id="Font Awesome 5 Brands" horiz-adv-x="640.4"> <font-face font-family="Font Awesome 5 Brands" units-per-em="512" ascent="448" descent="64" font-weight="400" font-style="Regular" />
And it's working like a charm. 馃槑

@cairnchampagne
Copy link

I'm also experiencing this problem with the PRO version:
Screen Shot 2019-03-21 at 10 29 50 AM

Just going to move over to this discussion. Hopefully, we can get this solved.

@keremciu
Copy link
Owner

@cairnchampagne did you look at your font glyphs at font book app?

@cairnchampagne
Copy link

@keremciu

First off - great plugin. I wish icon fonts were WAY easier to use in SKETCH but, for now, it is what it is.

I don't use font book. I use Font Explorer Pro. But, all the glyphs are there:
Screen Shot 2019-03-25 at 9 20 37 AM

I did the renaming trick through Visual Composer but, I don't get the full array of icons.

@keremciu
Copy link
Owner

@cairnchampagne oh, I think it's all about icon names differences between ttf file and svg file, I will try to learn how we can fix this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants