Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark Mode Support #165

Closed
richardsteers opened this issue Oct 9, 2018 · 5 comments
Closed

Dark Mode Support #165

richardsteers opened this issue Oct 9, 2018 · 5 comments

Comments

@richardsteers
Copy link

richardsteers commented Oct 9, 2018 •
edited
Loading

Search text & close icon is not visible when running dark mode in MacOS Mojave.

screen shot 2018-10-09 at 11 22 03 am
@ziyafenn
Copy link

I also have a problem on dark mode. Icons are displayed as "?" and search doesn't work.

@ioTus
Copy link

ioTus commented Oct 24, 2018

Same as @ziyafenn - icons displayed as "?" and search not working. Imported fonts as SVG

image

@ioTus
Copy link

ioTus commented Oct 24, 2018 •
edited
Loading

@ziyafenn solution for [?] icons: keremciu/font-bundles#30
You have to edit the SVG file font ID to match the font-face font-family:

<font id="fontawesome-pro" horiz-adv-x="640"> <font-face font-family="Font Awesome 5 Pro"

becomes

<font id="Font Awesome 5 Pro" horiz-adv-x="640"> <font-face font-family="Font Awesome 5 Pro"

Dark theme incompatibility still exists

@keremciu
Copy link
Owner

keremciu commented Nov 7, 2018

ups kinda big issue to fix. I will try to give it a time on weekend

@keremciu
Copy link
Owner

I published a new version for dark mode, I will try to manage this font-awesome 5 issues in a different branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ziyafenn @keremciu @ioTus @richardsteers