-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overlapping boxes #3
Comments
Can you try with this commit? 6536c0a |
Thanks for the response. I ran the same test and this is what I got. Box locations: CORRECT! I'll test with 9 more and come back with the results. |
Hi luenib, how can you make this program running well? Can you help me? |
ninankara, in order to see the positions of the boxes, you need to uncomment line 1143 of pack1.js I ran 2 more tests but this time they failed. These are the numbers:
Finding 1) Finding 2) TEST B) |
I made a new commit that reverts the changes made by last merge. This is the initial ported version of original repo. Unfortunately I do not have time to contribute to this project. Always open to pull request though. Can you please confirm this version has more close results? |
Hi All, so i tried the current commit by cloning the project, and like luenib said, the result is wrong. Then I tried the other commit, and as he said , the result was different and might be correct. This is what I got (6536c0a commit): This is the result from the current repo: the result from paper is:
list of unpacked boxes hmm i couldnt tell which one is better, but surely something need to be double checked and revised . 💃 |
I think I found it. Inside the function expression The problem with the original line is that Also, comment out line 1143 of the original commit. That will let you see the coordinates of the boxes. I modified other things while trying to find the bug, but I think the evaluation of I ran 5 tests and all came out good. EDIT: |
Were you guys able to get better results with the modifications? |
Thanks for this correction! It works great! |
It would be great if someone create a PR ^^ |
The solution is provided by luenib (https://github.com/luenib). For more details please check: keremdemirer#3 (comment)
I
undocumentedcommented out line 1143// layerthickness = layers[bestite].layerdim;
and now I see the list of boxes and their location inside the container. the problems is that some boxes overlap.
e.g.
Box1: 3,3,2
Box2: 3,2,1
Box3: 3,1,1
Container: 3,3,3
The location of the boxes are:
Box1: 0,0,0
Box2: 0,0,2
Box3: 0,0,2
As you can see, Box2 and Box3 are located in the same position.
Do you have an idea of what could be the problem?
Thanks
The text was updated successfully, but these errors were encountered: