Add \ to commands to avoid system aliases
#363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the position of option `KERL_BUILD_DEBUG_VM` from `Locations on disk` subsection to `Build configuration` as it is in fact a build configuration. Also fix option `KERL_BUILD_DIR`'s default not closing its `\``.
|
Thanks. Going to let CI run through this change, but planning to merge it. |
The `\` forces the script to execute the binary files on the `$PATH` and ignore aliases. This helps to build and install without problems even if people have alternative programs aliased to base GNU programs (like `fd` to `find` or `ripgrep` to `grep`).
|
I just had to interactively rebase and force push because there was some other commands I wanted escaped and didn't wanted to make a new commit for, so I reused the last commit. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.