Add CI for MacOS #427
Add CI for MacOS #427
Conversation
| @@ -17,20 +17,30 @@ jobs: | |||
| fail-fast: false | |||
There was a problem hiding this comment.
Changes are probable best viewed with "Hide whitespace", since this introduces an if which changes existing script indentation.
| default-jdk libxml2-utils procps valgrind binutils | ||
| echo 'KERL_RELEASE_TARGET=debug opt gcov gprof valgrind lcnt' >> $GITHUB_ENV | ||
| if [[ ${{matrix.os}} == macos* ]]; then | ||
| /bin/bash -c "$(curl -fsSL \ |
There was a problem hiding this comment.
The only differences, from Ubuntu, are this section and the one below (KERL_RELEASE_TARGET). I use Homebrew to ease the installation process of required tools...
| default-jdk libxml2-utils procps valgrind binutils | ||
| fi | ||
| if [[ ${{matrix.os}} == macos* ]]; then | ||
| echo 'KERL_RELEASE_TARGET=debug opt' >> $GITHUB_ENV |
There was a problem hiding this comment.
I single this if out so it's easier to check for the differences (and hopefully one day they can be the same - btw, we're not doing target asan for Ubuntu).
The targets were not testing aren't straightforward to achieve, at least with Homebrew. e.g. valgrind would come from an alternative source, gcov and gprof supposedly comes from Command Line Tools, but I can't seem to find gcov after installing those, and gprof's been deprecated, ...
If all goes well this can still be an acceptable first base for building upon.
There was a problem hiding this comment.
If debug and opt work then the rest should also work. No need to make things extra complicated in macOS.
There was a problem hiding this comment.
Hey, @garazdawi. I tried it with debug opt gcov, for example, and stuff started failing (thus the if). I didn't want to dig further, since I believed this was Ok for a first step, but maybe I could open a pull request where I add just gcov (so you can see the issue) and maybe have your 👀.
|
@jadeallenx, ready to merge when you are 😄 |
|
Thanks |
|
At this point I want to give you a commit bit for this repo if you want one... |
|
Hey, @jadeallenx. What's a commit bit? I don't think I've come across the term. Is that like collaboration rights? I'd be Ok with that, sure. Thank you. |
It's permission to make commits to this repository |
This adds MacOS-based CI with minimal changes to the workflow document.