Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore already applied patch #437

Merged
merged 1 commit into from Apr 8, 2023
Merged

Ignore already applied patch #437

merged 1 commit into from Apr 8, 2023

Conversation

magicant
Copy link
Contributor

@magicant magicant commented Apr 5, 2023

Fixes #434

@paulo-ferraz-oliveira
Copy link
Contributor

This should be Ok to merge (the CI issue should be fixed by #438), but I'm wondering if we could apply the same fix to all those other places where we use patch (?) @jadeallenx, thoughts?

@jadeallenx
Copy link
Collaborator

jadeallenx commented Apr 5, 2023 •
edited

I think we probably should use -N elsewhere yes.

@magicant
Copy link
Contributor Author

magicant commented Apr 6, 2023

Thanks for the suggestion, I've updated the patch. @paulo-ferraz-oliveira @jadeallenx

@paulo-ferraz-oliveira
Copy link
Contributor

We're running CI again. I believe if that passes this should be good to merge.

@jadeallenx jadeallenx merged commit 71bcb7d into kerl:master Apr 8, 2023
16 of 21 checks passed
@magicant magicant deleted the patch-1 branch April 9, 2023 03:01
@almirsarajcic almirsarajcic mentioned this pull request Apr 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building Erlang 23 freezes on macOS
3 participants
@magicant @paulo-ferraz-oliveira @jadeallenx