Fix is_older_than_x_days: use find instead of stat
#481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only relevant in case the lock file is present, but still... This was tested in: * macOS - 13.5.1 * Ubuntu - 22.04.3 I didn't test on FreeBSD (couldn't find an easy way to run it) but according to what I read in the `find` manual this solution should be working
paulo-ferraz-oliveira
force-pushed
the
fix/stat-for-st_mtime
branch
from
38686f3
to
90ec488
Compare
paulo-ferraz-oliveira
changed the title
statis_older_than_x_days: use find instead of stat
|
I had previously tested this only on macOS, but today I launched a Ubuntu container to start on a new pr and found this issue. |
jadeallenx
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm moving to
find, which seems to be more closely related in FreeBSD, Ubuntu and macOS, for example. (statwas also failing in Ubuntu, as it was only tested on macOS).