-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/improve output on errors #482
Fix/improve output on errors #482
Commits on Oct 22, 2023
-
Remove return/exit distinctions where not used
We don't document exit code We sometimes don't care for the return of a function (e.g. 0 is the same as 1, though 1 indicates to the developer that something should potentially be handled) As for the change to list_add I don't actually see how it could fail (attaching to a file, or creating one?) and if it does is _very_ unexpected situations we want it to fail louder
Configuration menu - View commit details
-
Copy full SHA for 0cabd97 - Browse repository at this point
Copy the full SHA 0cabd97View commit details -
Update .kerl/otp_releases inplace
This allow us to, at the same time: * create the file * return from inner functions, for exiting purposes * writing to stderr * without the output being consumed by sub-shells
Configuration menu - View commit details
-
Copy full SHA for 31f1bcf - Browse repository at this point
Copy the full SHA 31f1bcfView commit details -
In certain situations, I was getting execution stopping silently (e.g. 404 on curl calls) because we're using shortcuts such as || true, and || return, or even || exit without prior error messages, which this commit attempts to fix
Configuration menu - View commit details
-
Copy full SHA for 0f23603 - Browse repository at this point
Copy the full SHA 0f23603View commit details -
Error out on assertion site, not call site
When it's clear to do so, instead of bubbling up return values until we're ready to exit
Configuration menu - View commit details
-
Copy full SHA for 403eca4 - Browse repository at this point
Copy the full SHA 403eca4View commit details -
Use less return/exit indirections
Reduces the number of functions assert_ is ok to use, but then we have scattered exit vs. return which makes it harder to reason on Also, we move `assert_build_name_unused` to `is_build_name_used` to avoid double negation
Configuration menu - View commit details
-
Copy full SHA for 06c149a - Browse repository at this point
Copy the full SHA 06c149aView commit details -
Prevent return+exit in same function/scope
If the function is exiting we call exit If it's returning we prefer return (and exiting higher up)
Configuration menu - View commit details
-
Copy full SHA for f385275 - Browse repository at this point
Copy the full SHA f385275View commit details -
Previous changes allow us to prevent two calls to `get_active_path` while making sure: * we exit on error * always continue to function calls otherwise (we reduce a nesting level with this change)
Configuration menu - View commit details
-
Copy full SHA for df81849 - Browse repository at this point
Copy the full SHA df81849View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6079a69 - Browse repository at this point
Copy the full SHA 6079a69View commit details -
Configuration menu - View commit details
-
Copy full SHA for e139d49 - Browse repository at this point
Copy the full SHA e139d49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04cc564 - Browse repository at this point
Copy the full SHA 04cc564View commit details -
Configuration menu - View commit details
-
Copy full SHA for 479e5d3 - Browse repository at this point
Copy the full SHA 479e5d3View commit details -
Act on self-review: don't assume files aren't somehow protected
Prefer failure with controlled messages
Configuration menu - View commit details
-
Copy full SHA for 70a37c8 - Browse repository at this point
Copy the full SHA 70a37c8View commit details -
Act on self-review: ease maintenance of do_build function return
We always show_build_logfile with a message then autoclean with a file "pointer" With a function it'll be easier to not forget how to do cleanup, if the function changes in the future
Configuration menu - View commit details
-
Copy full SHA for fde8ee5 - Browse repository at this point
Copy the full SHA fde8ee5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2a56c3 - Browse repository at this point
Copy the full SHA b2a56c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf21ba3 - Browse repository at this point
Copy the full SHA cf21ba3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 785f984 - Browse repository at this point
Copy the full SHA 785f984View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff6bd1b - Browse repository at this point
Copy the full SHA ff6bd1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a256167 - Browse repository at this point
Copy the full SHA a256167View commit details -
Act on CI results: don't have CI fail with a new exit code
Due to the recent changes we started exiting with 1 on _kerl status_ when no installation is active
Configuration menu - View commit details
-
Copy full SHA for e71bef8 - Browse repository at this point
Copy the full SHA e71bef8View commit details
Commits on Oct 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f09a628 - Browse repository at this point
Copy the full SHA f09a628View commit details -
Configuration menu - View commit details
-
Copy full SHA for f5150bc - Browse repository at this point
Copy the full SHA f5150bcView commit details -
Act on CI results: choose warn instead error, sometimes
I think errors should always exit with a non-0 status ... but you might not always show an error when you exit with a non-0 status (this is context dependent)
Configuration menu - View commit details
-
Copy full SHA for 841284c - Browse repository at this point
Copy the full SHA 841284cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f7fcb26 - Browse repository at this point
Copy the full SHA f7fcb26View commit details
Commits on Oct 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8b1c6ab - Browse repository at this point
Copy the full SHA 8b1c6abView commit details