Ignore ownership and permissions of files in OTP source archives #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulo-ferraz-oliveira
approved these changes
Mar 12, 2024
|
@vassilevsky, before we merge this I'll ask you to rebase on top of a pull request I'll create and merge (that re-activates CI for pull requests - edit: #516). Sorry for the inconvenience, but I was hoping to have #507 merged, then decided to postpone it until 27.0-rc1 comes out. |
|
Sorry for the delay. CI was taking so long I moved to something else and kinda forgot about this. Feel free to rebase. |
vassilevsky
force-pushed
the
safe-extraction
branch
from
b2f936a
to
1852e2e
Compare
|
Rebased :) |
When run as root in some environments (such as Kaniko build in Docker executor in GitLab CI), Tar tries to set extracted files' uid, gid, suid, sgid, etc exactly as in the archive. This process can fail, because the build system might not have them.
vassilevsky
force-pushed
the
safe-extraction
branch
from
1852e2e
to
1b5ae63
Compare
|
Thanks for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When run as root in some environments (such as Kaniko build in Docker executor in GitLab CI), Tar tries to set extracted files' uid, gid, suid, sgid, etc exactly as in the archive. This process can fail, because the build system might not have them.
This change was discussed in issue #513.
I have checked BSD tar on macOS Sonoma, GNU tar in CentOS, Ubuntu, Debian (all latest), and these flags are present everywhere.