Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KERL_DOC_TARGETS needs to be quoted #520

Merged
merged 1 commit into from
Apr 16, 2024
Merged

KERL_DOC_TARGETS needs to be quoted #520

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions kerl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1196,11 +1196,11 @@ _do_build() {
if [ -n "$KERL_BUILD_DOCS" ]; then
notice "Building docs..."
# shellcheck disable=SC2154 # KERL_DOC_TARGETS is referenced but not assigned
if ! log_build_cmd "make docs DOC_TARGETS=$KERL_DOC_TARGETS"; then
if ! log_build_cmd "make docs DOC_TARGETS=\"$KERL_DOC_TARGETS\""; then
fail_do_build "building docs failed." "$2" "$1"
return 1
fi
if ! log_build_cmd "make release_docs DOC_TARGETS=$KERL_DOC_TARGETS RELEASE_ROOT=$KERL_BUILD_DIR/$2/release_$1"; then
if ! log_build_cmd "make release_docs DOC_TARGETS=\"$KERL_DOC_TARGETS\" RELEASE_ROOT=$KERL_BUILD_DIR/$2/release_$1"; then
fail_do_build "release of docs failed." "$2" "$1"
return 1
fi
Expand Down Expand Up @@ -1722,7 +1722,7 @@ do_install() {
error "couldn't cd into $ERL_TOP."
exit_install
fi
if ! log_install_cmd "ERL_TOP=$ERL_TOP make release_docs DOC_TARGETS=$KERL_DOC_TARGETS RELEASE_ROOT=$absdir"; then
if ! log_install_cmd "ERL_TOP=$ERL_TOP make release_docs DOC_TARGETS=\"$KERL_DOC_TARGETS\" RELEASE_ROOT=$absdir"; then
show_install_logfile "couldn't install docs for Erlang/OTP $rel ($build_name) in $absdir"
exit_install
fi
Expand Down