added tests for the orcid pattern.

kermitt2 · May 2, 2020 · 7dc2c4f · 7dc2c4f
1 parent 3b47d93
commit 7dc2c4f
Showing 1 changed file with 19 additions and 2 deletions.
diff --git a/grobid-core/src/test/java/org/grobid/core/utilities/TextUtilitiesTest.java b/grobid-core/src/test/java/org/grobid/core/utilities/TextUtilitiesTest.java
@@ -9,12 +9,12 @@
 
 import java.util.ArrayList;
 import java.util.List;
+import java.util.regex.Matcher;
 
 import static org.hamcrest.CoreMatchers.is;
 import static org.hamcrest.CoreMatchers.startsWith;
 import static org.hamcrest.MatcherAssert.assertThat;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.*;
 
 @Ignore
 public class TextUtilitiesTest extends EngineTest {
@@ -390,4 +390,21 @@ public void testIsAllUpperCaseOrDigitOrDot() throws Exception {
         assertThat(TextUtilities.isAllUpperCaseOrDigitOrDot("P.C.T."), is(true));
         assertThat(TextUtilities.isAllUpperCaseOrDigitOrDot("P.C,T."), is(false));
     }
+
+    @Test
+    public void testOrcidPattern() {
+        String[] falseOrcids = {"1234", "1234-5698-137X", "0000-0001-9877-137Y","http://orcid.fr/0000-0001-9877-137X"};
+        String[] trueOrcids = {"0000-0001-9877-137X", "http://orcid.org/0000-0001-9877-137X", "orcid.org/0000-0001-9877-137X"};
+        for(String falseOrcid :  falseOrcids) {
+            Matcher orcidMatcher = TextUtilities.ORCIDPattern.matcher(falseOrcid);
+            assertFalse (orcidMatcher.find());
+        }
+        for(String trueOrcid :  trueOrcids) {
+            Matcher orcidMatcher = TextUtilities.ORCIDPattern.matcher(trueOrcid);
+            if (orcidMatcher.find()) {
+                assertThat(orcidMatcher.group(1) + "-"
+                    + orcidMatcher.group(2) + "-" + orcidMatcher.group(3) + "-" + orcidMatcher.group(4) , is("0000-0001-9877-137X"));
+            }
+        }
+    }
 }