Skip to content

Commit

Permalink
Update documentation and dockerfile to include the init process when …
Browse files Browse the repository at this point in the history
…running docker images #312
  • Loading branch information
lfoppiano committed May 29, 2018
1 parent 7b7087b commit a55e326
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
6 changes: 6 additions & 0 deletions Dockerfile
Expand Up @@ -66,6 +66,12 @@ WORKDIR /opt/grobid

ENV JAVA_OPTS=-Xmx4g

# Add Tini
ENV TINI_VERSION v0.18.0
ADD https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini /tini
RUN chmod +x /tini
ENTRYPOINT ["/tini", "--"]

CMD ["./grobid-service/bin/grobid-service", "server", "grobid-service/config/config.yaml"]

ARG GROBID_VERSION
Expand Down
6 changes: 4 additions & 2 deletions doc/Grobid-docker.md
Expand Up @@ -90,9 +90,11 @@ You should see something like:
For more information see the [GROBID main page](https://github.com/kermitt2/grobid/blob/master/Readme.md).

<h5>pdf2xml zombie processes</h5>
When running docker without an initi process, the pdf2xml processes will be hang as zombie eventually filling
~~When running docker without an init process, the pdf2xml processes will be hang as zombie eventually filling
up the machine. The docker solution is to use `--init` as parameter when running the image, however we are discussing
some more long-term solution compatible with Kubernetes for example.
some more long-term solution compatible with Kubernetes for example.~~
The solution shipped with the current Dockerfile, using tini (https://github.com/krallin/tini) should provide the correct init process to cleanup
killed processes.


<h4>Build caveat</h4>
Expand Down

0 comments on commit a55e326

Please sign in to comment.