Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs suggest setting Grobid home by environment variable, but not supported #286

Closed
borkdude opened this issue Feb 15, 2018 · 3 comments
Closed

Comments

@borkdude
Copy link

The code example at https://grobid.readthedocs.io/en/latest/Grobid-java-library/ suggests setting the Grobid home directory with an environment variable:

location (classpath, ../grobid-home, ../../grobid-home or in the environment variable GROBID_HOME

but when I try this, it doesn't work. Glancing at the source code, this variable is not read at all.

https://github.com/kermitt2/grobid/blob/master/grobid-core/src/main/java/org/grobid/core/main/GrobidHomeFinder.java

@kermitt2
Copy link
Owner

Hello @borkdude !
We can't anymore set the Grobid home directory with an environment variable, we remove this possibility because it was not considered a good practice (for instance when working with different grobid-home).
Unfortunately I forget to update this comment in this part of the doc...
With the Java library, the way to go for setting GROBID_HOME is the property file.

kermitt2 added a commit that referenced this issue Feb 20, 2018
@borkdude
Copy link
Author

No problem. Just reporting, not complaining :-) I went with Docker for now anyway.

@de-code
Copy link
Collaborator

de-code commented Aug 21, 2019

Could we maybe add this back in as an option?
It could use the system property if set, otherwise check the environment variable.

de-code pushed a commit to elifesciences/grobid that referenced this issue Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants