Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] build docker from local source #306

Merged
merged 1 commit into from Apr 24, 2018

Conversation

de-code
Copy link
Collaborator

@de-code de-code commented Apr 19, 2018

@lfoppiano this is a potential revision that we can discuss next week (I thought it's good to have something to look at).

Advantages:

  • can be built from local source and no direct link to github repo
  • docker can use cache (although in the current version it is not yet very effective unless we can cache the gradle dependencies, e.g. by mounting the .gradle volume)
  • as far as I know, that is how docker is usually used (otherwise the Dockerfile could be outside the repo)
  • changes to the project structure / build requirements can be reflected in the Dockerfile together with the code
  • you could easily integrate it into the CI build workflow to push docker images for commits

Changes to release:

  • rather than building the release image locally, it might be better do that on a CI machine
  • otherwise you could instead have a very simple script that checks out a particular version and then builds the docker image (instead of doing the git checkout as part of the docker build)

@lfoppiano
Copy link
Collaborator

Thanks @de-code. 👍

@coveralls
Copy link

Coverage Status

Coverage remained the same at 38.684% when pulling 9338013 on de-code:local-dockerfile into a529f40 on kermitt2:master.

@lfoppiano lfoppiano merged commit 1d4f339 into kermitt2:master Apr 24, 2018
de-code pushed a commit to elifesciences/grobid that referenced this pull request Nov 29, 2019
[wip] build docker from local source

Former-commit-id: 1d4f339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants