Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pdfalto parser fixes #496

Merged
merged 10 commits into from Oct 14, 2019
Merged

Pdfalto parser fixes #496

merged 10 commits into from Oct 14, 2019

Conversation

lfoppiano
Copy link
Collaborator

This should solve the issue #495 and add some more unit tests

@coveralls
Copy link

coveralls commented Sep 4, 2019 •
edited

Coverage Status

Coverage decreased (-0.02%) to 37.296% when pulling 0c8863b on pdfalto_parser_fixes into 472324a on master.

kermitt2
kermitt2 reviewed Sep 28, 2019
View reviewed changes
Copy link
Owner

@kermitt2 kermitt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So after aligning grobid and pdfalto, we finally need current pdfalto master built executable for mac os and windows.

grobid-core/src/main/java/org/grobid/core/sax/PDFALTOSaxHandler.java Outdated Show resolved Hide resolved
@lfoppiano
Copy link
Collaborator Author

lfoppiano commented Oct 2, 2019 •
edited

@Aazhar we've currently failed to build pdfalto for windows. We would need that for the new release of grobid, so that the pdfalto builds are aligned.

Could you please try to build it and let me know what is the procedure and which libraries should be used? There seems to be a problem with aconf.h when using windows + cygwin. (cc @flydutch)

@kermitt2 kermitt2 merged commit f85acd5 into master Oct 14, 2019
This was referenced Oct 14, 2019
Closed
Closed
Closed
@lfoppiano lfoppiano deleted the pdfalto_parser_fixes branch October 18, 2019 08:17
tantikristanti pushed a commit that referenced this pull request Nov 15, 2019
@kermitt2
Merge pull request #496 from kermitt2/pdfalto_parser_fixes
bd2b272 
pdfalto binaries update
pdfalto parser updates
Fix for #509 #152 
Doc update

Former-commit-id: f85acd5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kermitt2 kermitt2 kermitt2 left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lfoppiano @coveralls @kermitt2