Check whether annotation is orcid and add orcid to author. #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the slow review! It works very well when orcid annotations are present, both for correcting names and extracting the orcid and no effect on the normal cases according ot my tests. Thanks a lot Achraf ! |
|
ok for some unknown reason, it does not work after merging :/ |
kermitt2
added a commit
that referenced
this pull request
Aug 11, 2020
|
OK I found the problem, it works again as expected when merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix #512
Checks whether an orcid annotation is intersecting with author names , when the annotation is pointing to an ORCID pattern then recover the author name and add ORCID ID