Fix NullPointer exception in PDFALTOOutlineSaxHandler #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I observed the following error. févr. 12, 2021 3:20:44 PM org.grobid.core.document.Document addTokenizedDocument GRAVE: Cannot parse file: my_dir/grobid-0.6.1/grobid-home/tmp/ZW3PpM4E9g.lxml_outline.xml févr. 12, 2021 3:20:44 PM org.grobid.core.document.Document addTokenizedDocument GRAVE: Cannot parse file: my_dir/grobid-0.6.1/grobid-home/tmp/ZW3PpM4E9g.lxml_outline.xml févr. 12, 2021 3:20:46 PM org.grobid.core.engines.ProcessEngine createTraining INFOS: 2 files processed. it originates in an illegal nullPointer access in file PDFALTOOutlineSaxHandler.java. In understand that the error is not that "GRAVE". According to @kermitt2, it is simply one of the generated XML file resulting from the PDF parsing which is not XML valid (very frequent) - it has no impact because the outline file (containing the table of content outline if available embedded in the PDF) is not exploited by GROBID for the moment - it's to allow some possible improvements in the future. The error is more a reminder for the developers... the XML parser that classifies it as "GRAVE" but it would be rather INFO for us. Unfortunately, a side effect might have been overlooked. If father is null, then father.addChild(currentNode) is called with a nullPointer exception. This exception is caught by catch (Exception e) at line 372 in grobid-core/src/main/java/org/grobid/core/document/Document.java where the error message "Cannot parse" is misleading. I think an additional else is just missing.
I cleaned up the correction as requested. Luc.
…ing a test case, rename test to match the class name
kermitt2
reviewed
Apr 11, 2021
grobid-core/src/main/java/org/grobid/core/sax/PDFALTOOutlineSaxHandler.java
Outdated
Show resolved
Hide resolved
grobid-core/src/main/java/org/grobid/core/sax/PDFALTOOutlineSaxHandler.java
Outdated
Show resolved
Hide resolved
grobid-core/src/main/java/org/grobid/core/sax/PDFALTOOutlineSaxHandler.java
Show resolved
Hide resolved
grobid-core/src/main/java/org/grobid/core/sax/PDFALTOOutlineSaxHandler.java
Show resolved
Hide resolved
grobid-core/src/test/java/org/grobid/core/sax/PDFALTOOutlineSaxHandlerTest.java
Show resolved
Hide resolved
|
Ready to merge, no? |
|
Yes 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... update of #715
CC @lucbouge