Skip to content

Commit

Permalink
Make it work on older MiniTest versions.
Browse files Browse the repository at this point in the history
Fixes #26.
  • Loading branch information
Alexander Kern committed Jul 31, 2012
1 parent 2ee8d33 commit 633279f
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 13 deletions.
4 changes: 0 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,6 @@ The following reporters are provided:
MiniTest::Reporters::RubyMineReporter # => Reporter designed for RubyMine IDE and TeamCity CI server; see below
MiniTest::Reporters::GuardReporter # => Integrates with guard-minitest to provide on-screen notifications

## TODO ##

* Add some example images of the reporters.

## Note on Patches/Pull Requests ##

* Fork the project.
Expand Down
7 changes: 5 additions & 2 deletions lib/minitest/before_test_hook.rb
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
module MiniTest
module BeforeTestHook
def before_setup
def self.before_test(instance)
runner = MiniTest::Unit.runner

if runner.respond_to?(:before_test)
runner.before_test(self.class, __name__)
runner.before_test(instance.class, instance.__name__)
end
end

def before_setup
BeforeTestHook.before_test(self)
super
end
end
Expand Down
8 changes: 7 additions & 1 deletion lib/minitest/reporters.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,13 @@ def self.use!(console_reporters = ProgressReporter.new, env = ENV)
end

def self.include_hook!
Unit::TestCase.send(:include, BeforeTestHook)
if Unit::VERSION >= "3.3.0"
Unit::TestCase.send(:include, BeforeTestHook)
else
Unit::TestCase.send(:define_method, :before_setup) do
BeforeTestHook.before_test(self)
end
end
end

def self.choose_reporters(console_reporters, env)
Expand Down
2 changes: 1 addition & 1 deletion minitest-reporters.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ Gem::Specification.new do |s|

s.rubyforge_project = 'minitest-reporters'

s.add_dependency 'minitest', '>= 2.0', '< 4.0'
s.add_dependency 'minitest', '>= 2.12', '< 4.0'
s.add_dependency 'ansi'
s.add_dependency 'powerbar'
s.add_dependency 'builder'
Expand Down
6 changes: 1 addition & 5 deletions test/minitest/backtrace_filter_test.rb
Original file line number Diff line number Diff line change
@@ -1,29 +1,25 @@
require "test_helper"

module MiniTestReportersTest
class BacktraceFilterTest < MiniTest::Unit::TestCase
class BacktraceFilterTest < TestCase
def setup
@default_filter = MiniTest::BacktraceFilter.default_filter
@filter = MiniTest::BacktraceFilter.new
@backtrace = ["foo", "bar", "baz"]
end

def test_adding_filters
skip "test"
@filter.add_filter(/foo/)
assert @filter.filters?("foo")
refute @filter.filters?("baz")
end

def test_filter_backtrace_when_first_line_is_filtered
sleep 5
assert false
@filter.add_filter(/foo/)
assert_equal ["bar", "baz"], @filter.filter(@backtrace)
end

def test_filter_backtrace_when_middle_line_is_filtered
raise "foo"
@filter.add_filter(/bar/)
assert_equal ["foo"], @filter.filter(@backtrace)
end
Expand Down

0 comments on commit 633279f

Please sign in to comment.