Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use DelegateReporter if it's been explicitly asked for. #237

Conversation

pnomolos
Copy link

This will mean that the reporters are only overridden if Minitest::Reporters.use! has been called.

The respond_to? check is for cases where the plugin is on your GEM_PATH but you haven't actually required the gem.

@os97673
Copy link
Collaborator

os97673 commented Oct 2, 2017

interesting idea, but, perhaps, we should have empty plugin_minitest_reporter_init and rely on use!. What do you think?

@zenspider
Copy link

Either suggestion will address my concerns documented in #247. This is really needed as minitest-reporters breaks other plugins.

@os97673
Copy link
Collaborator

os97673 commented Oct 6, 2019

I personally believe that there is no good way to avoid the breakage and provide a convenient behavior for users. All this plugin idea doesn't work because some reporters naturally fight for the same medium to show the report (e.g. minitest itself enable a report which reports to a console and it means no other reporters can report to it :( )

So, I'm closing the PR and will think what is the best way to avoid such problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants