Add support for minitest-reporters #3
Conversation
|
Thanks for the patch! Unfortunately, this approach invites the slippery slope, where minitest-parallel_fork becomes expected to support all minitest plugins. Really, minitest should be modified not to automatically load plugins, or provide some way to control which plugins are loaded. If that can't be done, I'd be OK with moving the stat_reporter detection code to a method that you could override. But I'm not OK with having minitest-parallel_fork depend in any way on minitest-reporters (even as a development dependency). |
|
@jeremyevans I opened an issue, with the suggestion that this not happen until MT6 anyway. I'd be grateful if you would move the |
|
Thanks. Hopefully Minitest will fix the issue. I'll extract the |
|
minitest-reporters/minitest-reporters#247 and the proper solution has already been submitted: |
because even having it in the Gemfile messes with minitest-parallel_fork, sigh. For context, see: - minitest-reporters/minitest-reporters#247 - jeremyevans/minitest-parallel_fork#3
**What problem is this PR intended to solve?** drop minitest-reporters, because even having it in the Gemfile messes with minitest-parallel_fork, sigh. For context, see: - minitest-reporters/minitest-reporters#247 - jeremyevans/minitest-parallel_fork#3 Also, avoid psych 5.1.1 because of ruby/psych#655
Just to warn you, due to how Minitest's plugins are handled, even having
minitest-reporterson your gem path means it will be automatically loaded.