Skip to content

Commit

Permalink
bpf, docs: Fix typos in instructions-set.rst
Browse files Browse the repository at this point in the history
* "imm32" should just be "imm"
* Add blank line to fix formatting error reported by Stephen Rothwell [0]

[0]: https://lore.kernel.org/bpf/20240206153301.4ead0bad@canb.auug.org.au/T/#u

Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Acked-by: David Vernet <void@manifault.com>
Link: https://lore.kernel.org/r/20240206045146.4965-1-dthaler1968@gmail.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
  • Loading branch information
Dave Thaler authored and Alexei Starovoitov committed Feb 6, 2024
1 parent c7dcb6c commit 563918a
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions Documentation/bpf/standardization/instruction-set.rst
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ corresponds to a set of instructions that are mandatory. That is, each
instruction has one or more conformance groups of which it is a member.

This document defines the following conformance groups:

* base32: includes all instructions defined in this
specification unless otherwise noted.
* base64: includes base32, plus instructions explicitly noted
Expand Down Expand Up @@ -289,11 +290,11 @@ where '(u32)' indicates that the upper 32 bits are zeroed.

``BPF_XOR | BPF_K | BPF_ALU`` means::

dst = (u32) dst ^ (u32) imm32
dst = (u32) dst ^ (u32) imm

``BPF_XOR | BPF_K | BPF_ALU64`` means::

dst = dst ^ imm32
dst = dst ^ imm

Note that most instructions have instruction offset of 0. Only three instructions
(``BPF_SDIV``, ``BPF_SMOD``, ``BPF_MOVSX``) have a non-zero offset.
Expand Down Expand Up @@ -511,7 +512,7 @@ instructions that transfer data between a register and memory.

``BPF_MEM | <size> | BPF_ST`` means::

*(size *) (dst + offset) = imm32
*(size *) (dst + offset) = imm

``BPF_MEM | <size> | BPF_LDX`` means::

Expand Down

0 comments on commit 563918a

Please sign in to comment.