Skip to content

Commit

Permalink
selftests/bpf: Add a negative test for stack accounting in jit mode
Browse files Browse the repository at this point in the history
The new test is very similar to test_global_func1.c, but
is modified to fail on jit mode.

Signed-off-by: Yonghong Song <yonghong.song@linux.dev>
  • Loading branch information
Yonghong Song authored and Kernel Patches Daemon committed Feb 13, 2024
1 parent 8e9ec7e commit 848aa3e
Show file tree
Hide file tree
Showing 2 changed files with 47 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tools/testing/selftests/bpf/prog_tests/test_global_funcs.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
#include "test_global_func15.skel.h"
#include "test_global_func16.skel.h"
#include "test_global_func17.skel.h"
#include "test_global_func18.skel.h"
#include "test_global_func_ctx_args.skel.h"

#include "bpf/libbpf_internal.h"
Expand Down Expand Up @@ -140,6 +141,8 @@ void test_test_global_funcs(void)
{
if (!env.jit_enabled) {
RUN_TESTS(test_global_func1);
} else {
RUN_TESTS(test_global_func18);
}

RUN_TESTS(test_global_func2);
Expand Down
44 changes: 44 additions & 0 deletions tools/testing/selftests/bpf/progs/test_global_func18.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
// SPDX-License-Identifier: GPL-2.0-only
/* Copyright (c) 2024 Meta Platforms, Inc. and affiliates. */
#include <stddef.h>
#include <linux/bpf.h>
#include <bpf/bpf_helpers.h>
#include "bpf_misc.h"

#define MAX_STACK1 (512 - 3 * 32 + 8)
#define MAX_STACK2 (3 * 32)

__attribute__ ((noinline))
int f1(struct __sk_buff *skb)
{
return skb->len;
}

int f3(int, struct __sk_buff *skb, int);

__attribute__ ((noinline))
int f2(int val, struct __sk_buff *skb)
{
volatile char buf[MAX_STACK1] = {};

__sink(buf[MAX_STACK1 - 1]);

return f1(skb) + f3(val, skb, 1);
}

__attribute__ ((noinline))
int f3(int val, struct __sk_buff *skb, int var)
{
volatile char buf[MAX_STACK2] = {};

__sink(buf[MAX_STACK2 - 1]);

return skb->ifindex * val * var;
}

SEC("tc")
__failure __msg("combined stack size of 3 calls is 528")
int global_func18(struct __sk_buff *skb)
{
return f1(skb) + f2(2, skb) + f3(3, skb, 4);
}

0 comments on commit 848aa3e

Please sign in to comment.