selftests/bpf: fix probe_user test failure with clang build kernel #1837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Master branch: e7d5184 |
|
Master branch: 4c9f093 |
kernel-patches-bot
force-pushed
the
series/553639=>bpf-next
branch
from
b246cc0
to
5e403c1
Compare
|
Master branch: c3e8c44 |
kernel-patches-bot
force-pushed
the
series/553639=>bpf-next
branch
from
5e403c1
to
3880c1d
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=553639 expired. Closing PR. |
clang build kernel failed the selftest probe_user. $ ./test_progs -t probe_user $ ... $ test_probe_user:PASS:get_kprobe_res 0 nsec $ test_probe_user:FAIL:check_kprobe_res wrong kprobe res from probe read: 0.0.0.0:0 $ #94 probe_user:FAIL The test attached to kernel function __sys_connect(). In net/socket.c, we have int __sys_connect(int fd, struct sockaddr __user *uservaddr, int addrlen) { ...... } ... SYSCALL_DEFINE3(connect, int, fd, struct sockaddr __user *, uservaddr, int, addrlen) { return __sys_connect(fd, uservaddr, addrlen); } The gcc compiler (8.5.0) does not inline __sys_connect() in syscall entry function. But latest clang trunk did the inlining. So the bpf program is not triggered. To make the test more reliable, let us kprobe the syscall entry function instead. Note that x86_64, arm64 and s390 have syscall wrappers and they have to be handled specially. Signed-off-by: Yonghong Song <yhs@fb.com>
|
Master branch: 72e1781 |
kernel-patches-bot
force-pushed
the
series/553639=>bpf-next
branch
from
3880c1d
to
7844e15
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=554695 irrelevant now. Closing PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: selftests/bpf: fix probe_user test failure with clang build kernel
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=553639