Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libbpf: ignore STT_SECTION symbols in 'maps' section #1840

Closed
wants to merge 2 commits into from

Conversation

kernel-patches-bot
Copy link

Pull request for series with
subject: libbpf: ignore STT_SECTION symbols in 'maps' section
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=553739

@kernel-patches-bot
Copy link
Author

Master branch: e7d5184
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=553739
version: 1

Nobody and others added 2 commits September 27, 2021 15:32
When parsing legacy map definitions, libbpf would error out when
encountering an STT_SECTION symbol. This becomes a problem because some
versions of binutils will produce SECTION symbols for every section when
processing an ELF file, so BPF files run through 'strip' will end up with
such symbols, making libbpf refuse to load them.

There's not really any reason why erroring out is strictly necessary, so
change libbpf to just ignore SECTION symbols when parsing the ELF.

Cc: Jiri Benc <jbenc@redhat.com>
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
@kernel-patches-bot
Copy link
Author

Master branch: 4c9f093
series: https://patchwork.kernel.org/project/netdevbpf/list/?series=553739
version: 1

@kernel-patches-bot
Copy link
Author

At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=553739 irrelevant now. Closing PR.

@kernel-patches-bot kernel-patches-bot deleted the series/553739=>bpf-next branch September 28, 2021 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants